#365 remove prflight check #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…combine_solana_rcp_requests
otselnik
pushed a commit
that referenced
this pull request
Dec 27, 2021
* impl * fix emulate call * set temporary evm_loader branch * fix last commit * temporary commit: set evm_loader version * fix emulate * Revert "temporary commit: set evm_loader version" This reverts commit 2383212. * Revert "fix last commit" This reverts commit c51e198. * Revert "set temporary evm_loader branch" This reverts commit 5bb8c77.
…o 365_remove_prflight_check
ivandzen
reviewed
Dec 30, 2021
| try_one_step = False | ||
| found_errors = False | ||
|
|
||
| logger.debug(f"Send bucked combined: {self.instruction_type}") |
| @@ -131,13 +130,10 @@ def _getAccountData(self, account, expected_length, owner=None): | |||
| def send_transaction(self, trx, eth_trx, reason=None): | |||
| for _i in range(RETRY_ON_FAIL): | |||
| reciept = self.send_transaction_unconfirmed(trx) | |||
There was a problem hiding this comment.
Why don't we catch exception here? send_transaction_unconfirmed still can throw error
There was a problem hiding this comment.
We only caught "could not confirm transaction" exception which is removed.
There was a problem hiding this comment.
If send_transaction_unconfirmed throws so be it.
ivandzen
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
RETRY_ON_BLOCKEDvariable defining count of retries on blocked accounts. Inenvironment.pyit is set to a minimum of 1.Removed
RuntimeErrorfromconfirm_multiple_transactions.collect_resultsandcollect_resultnow return response["result"]. And all corresponding changes by removing ['result']Write sent by packs of 20.
CombinedContinue sent by 16.
Iterative execution performed By trying to send bucked. If got error of blocked or steps exceeded - retry until success and than go back to bucked send. If there were no errors or result retry bucked.
If got error and no succec transactions sent just return error. If were success trxs try cancel.