#455 rewrite transaction reciept with finalized data #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afalaleev
previously approved these changes
Jan 20, 2022
…ts_for_not_finalized_transactions
afalaleev
reviewed
Jan 21, 2022
proxy/indexer/indexer_db.py
Outdated
| @@ -59,21 +60,21 @@ def _fill_block_from_net(self, block: SolanaBlockDBInfo): | |||
| block.signs = net_block['signatures'] | |||
| block.parent_hash = '0x' + base58.b58decode(net_block['previousBlockhash']).hex() | |||
| block.time = net_block['blockTime'] | |||
| block.finalized = ("confirmed" == FINALIZED) | |||
| block.finalized = (commitment == FINALIZED) | |||
There was a problem hiding this comment.
The error in this place.
The block can be loaded from DB with the finalized status, but here it is overwritten.
Here should be:
block.finalized = block.finalized or ('confirmed' == FINALIZED)
In this case:
- Indexer saves blocks and txs with finalized status
- Sender saves blocks and txs with confirmed status
afalaleev
approved these changes
Jan 21, 2022
afalaleev
deleted the
455_request_receipts_for_not_finalized_transactions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.