Ndev 3482 refactor neon evm tests #481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. changed environment fixture 2. added fixtures for solana, neon_api, neon_rpc clients 2. moved evm vars from constants.py to envs.json (local) 3. slightly refactored type hints of functions
|
Please check README file ( section about how to run evm tests) |
kristinaNikolaevaa
requested changes
Jan 17, 2025
| proxy_url: str | ||
| tracer_url: str | ||
| solana_url: str | ||
| faucet_url: str | ||
| network_ids: dict | ||
| spl_neon_mint: str | ||
| sol_mint_id_string: str | ||
| neon_mint_id_string: str |
There was a problem hiding this comment.
neon_mint_id_string == spl_neon_mint (see below)
sol_mint_id_string is the same for all stands. Lets het the value from solana lib, it is called NATIVE_MINT
lets delete both of them
|
|
||
|
|
||
| def prepare_operator(key_file, evm_loader: EvmLoader): | ||
| def prepare_operator(key_file: pathlib.Path | str, evm_loader: EvmLoader, environment: EnvironmentConfig) -> Keypair: |
There was a problem hiding this comment.
we have chain ids in evm_loader
environment can be deleted
There was a problem hiding this comment.
please check that new params are optional
otherwise add them to each section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.