Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

ModConfigurationKey<Nullable<T>>.Validate does not pass when given a null #78

Closed
badhaloninja opened this issue Sep 28, 2022 · 2 comments · Fixed by #79
Closed

ModConfigurationKey<Nullable<T>>.Validate does not pass when given a null #78

badhaloninja opened this issue Sep 28, 2022 · 2 comments · Fixed by #79
Assignees
@zkxs
Labels
bug Something isn't working

Comments

@badhaloninja
Copy link

ModConfigurationKey.Validate fails when giving null on a Nullable<T> key
@badhaloninja badhaloninja mentioned this issue Sep 28, 2022
Closed
@XDelta XDelta added the bug Something isn't working label Sep 28, 2022
@zkxs zkxs mentioned this issue Oct 1, 2022
Merged
@zkxs zkxs self-assigned this Oct 1, 2022
@zkxs zkxs closed this as completed in #79 Oct 1, 2022
@zkxs
Copy link
Collaborator

zkxs commented Oct 1, 2022

This should be fixed in 1.12.4, but I haven't actually tested it myself.

@EIA485
Copy link
Member

EIA485 commented Oct 1, 2022 •
edited
Loading

ive confirmed that #79 fixed the issue by testing against Toxic-Cookie/GenericSettings with badhaloninja/neosModSettings

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zkxs zkxs

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Nullable<T> configs neos-modding-group/NeosModLoader
4 participants
@badhaloninja @zkxs @XDelta @EIA485