Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

Fix Nullable<T> configs #79

Merged
merged 2 commits into from
Oct 1, 2022
Merged

Fix Nullable<T> configs #79

merged 2 commits into from
Oct 1, 2022

Conversation

zkxs
Copy link
Collaborator

@zkxs zkxs commented Oct 1, 2022

This should fix #78.

@zkxs zkxs merged commit 0b3bea3 into master Oct 1, 2022
@zkxs
Copy link
Collaborator Author

zkxs commented Oct 1, 2022

One of these days I'll figure out wtf is up with C# unit tests

but not today

@EIA485
Copy link
Member

EIA485 commented Oct 1, 2022

ive confirmed that this fixed the issue by testing against Toxic-Cookie/GenericSettings with badhaloninja/neosModSettings

@zkxs zkxs deleted the nullable-config branch February 26, 2023 04:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModConfigurationKey<Nullable<T>>.Validate does not pass when given a null
2 participants