kickstart:site doesn't work properly

[jonnitto]

After running the kickstart:site wizard, the generated package is in the Application folder, but the package doesn't get written into the root composer.json file.

Some thoughts:

• Should the package not be written into the Sites folder or even better into the DistributionPackages?
• The package should be included in the root composer.json
• After running the wizard a message like Please run the setup or import the site with the flow command site:import --package-key Foo.Bar should be shown.
• If a site package is already defined a warning should be shown

[jonnitto]

Wdyt, @Wyndala?

[jonnitto]

I've tested the behavior before PR #3089

The old implementation works the same way, so the wrong behavior is quite old.

[jonnitto]

Some further points: As it seems kickstart:package has the same problems, the package doesn't get added to the composer.json.

[jonnitto]

After a short call with @Wyndala we found out that the neos-development-distribution has a missing entry and folder (DistributionPackages) compared to the neos-base-distribution:

"repositories": {
  "distributionPackages": {
    "type": "path",
    "url": "./DistributionPackages/*"
  }
}

With this folder and entry in place, the package get's generated into the DistributionPackages folder and also added to the root composer.json

[jonnitto]

neos/neos-development-distribution#59