Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!! TASK: Make composer autoloader the default #2288

Merged
merged 6 commits into from
Dec 7, 2020

Conversation

albe
Copy link
Member

@albe albe commented Nov 29, 2020

The old behaviour can now still be achieved by setting FLOW_ONLY_COMPOSER_LOADER=false, but is (still) deprecated and will be gone at some point.

This is a breaking change if you relied on the old behavior, specifically on the fact that Flow used to consider all packages underneath the /Packages folder.

From now on, packages will only be loaded if they are properly installed via composer!

Related to #2262

The old behaviour can now still be achieved by setting `FLOW_ONLY_COMPOSER_LOADER=false`, but is (still) deprecated and will be gone at some point.
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks for taking care.

I can't really judge if our custom ClassLoader can be disabled without further side effects. Probably @kitsunet can tell that. Or we just test it :)

@bwaidelich
Copy link
Member

If we agree to this, we should also update the docs (see #2280 (comment))

Co-authored-by: Bastian Waidelich <[email protected]>
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading (and Neos demo seems to work with it) but I would like another opinion on that since I never really understood the differences of our own ClassLoader tbh

@bwaidelich
Copy link
Member

bwaidelich commented Dec 1, 2020

Note: I just realized that ./flow kickstart:site (and probably also ./flow kickstart:package) doesn't actually add the new package to the composer manifest (see neos/neos-development-collection#3217). I could imagine that this will break without our own ClassLoader, right?

@albe
Copy link
Member Author

albe commented Dec 5, 2020

Good point. That's definitely something to check.

@kdambekalns
Copy link
Member

I could imagine that this will break without our own ClassLoader, right?

That is fixed by now (see neos/neos-development-distribution#59)

Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@kitsunet kitsunet merged commit 4ab5fc0 into master Dec 7, 2020
@kitsunet kitsunet deleted the albe-composer-autoloader branch December 7, 2020 09:45
@albe
Copy link
Member Author

albe commented Dec 7, 2020

🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants