-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!!! TASK: Make composer autoloader the default #2288
Conversation
The old behaviour can now still be achieved by setting `FLOW_ONLY_COMPOSER_LOADER=false`, but is (still) deprecated and will be gone at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, thanks for taking care.
I can't really judge if our custom ClassLoader can be disabled without further side effects. Probably @kitsunet can tell that. Or we just test it :)
If we agree to this, we should also update the docs (see #2280 (comment)) |
Co-authored-by: Bastian Waidelich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 by reading (and Neos demo seems to work with it) but I would like another opinion on that since I never really understood the differences of our own ClassLoader tbh
Note: I just realized that |
Good point. That's definitely something to check. |
That is fixed by now (see neos/neos-development-distribution#59) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me.
🤞 |
The old behaviour can now still be achieved by setting
FLOW_ONLY_COMPOSER_LOADER=false
, but is (still) deprecated and will be gone at some point.This is a breaking change if you relied on the old behavior, specifically on the fact that Flow used to consider all packages underneath the
/Packages
folder.From now on, packages will only be loaded if they are properly installed via composer!
Related to #2262