Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Remove workspace creation from EditorContentStreamZookeeper #5299

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Oct 17, 2024

Resolves: #4401

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Copy link
Member

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and supports

  • switch site to another cr where user workspace was not created yet
  • cr:prune + cr:import while user is logged in (a reload of the backend may be necessary , since this is a very invasive dev task this is an ok way to recover from the problem)

@bwaidelich bwaidelich merged commit ad80c86 into neos:9.0 Oct 22, 2024
9 checks passed
@mhsdesign mhsdesign deleted the bugfix/4401-harden-user-workspace-creation-for-login branch October 22, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: (9.0) User Workspace is null if first login to the site happens via "/neos/switch/to/..."
3 participants