-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parse arguments properly in certain circumstances #103
Conversation
Hmm, that fails two tests ( |
that failing would make sense, i'll update the tests accordingly :) but idk why CI didn't catch that |
Seems like that might've fixed one of the tests anyways |
because you didn't push the generated |
I think you also need to add |
And can you add a new test for these? |
2dc09e1
to
3a98393
Compare
done |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This adds a regression in b:sh_indent_options['default'] Default amount of indent. The There's also a few other regressions in taglinks, such as |
Added another ugly hack for it, lmk of any others oddities |
Still breaks the taglink in |
This flew off the radar...what's the taglink in |
|
|
||
nvim_foo({bar}, {baz}) | ||
|
||
nvim_buf_detach_event[{buf}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
args may have whitespace ({arg arg}
) but that's already tested on line 4
Actually, allowing whitespace in args is not part of vim's help syntax, and it causes lots of problems. So I reverted that "feature" in #97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks worth a try. Thanks!
Will revisit/rebase this after #97 |
Rebased in #108 |
'[', | ||
']', | ||
'[\'', | ||
'\']', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are ['
and ']
important special cases or could we drop these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that was done to work around the b:sh_indent_options mentioned earlier. So if those are fixed by your other changes (or deemed "won't fix" by simply wrapping them in backticks) they could indeed go.
Closes #102
Didn't test everything imaginable, but the ones linked in the issue parse fine now