Correct instructions for Docker build #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the instruction for the cuda-architecture specific Docker build.
|
@Zunhammer - since you were the last to touch this line, could you review? |
|
You are right, either --tag or -t is the correct command. Thanks for fixing. The "-f Dockerfile" is optional though. |
|
You're welcome :) I left the '-f Dockerfile' to be consistent with the rest of the examples, and I like its explicitness. |
tancik
approved these changes
Mar 8, 2023
f-dy
pushed a commit
to f-dy/nerfstudio
that referenced
this pull request
Mar 8, 2023
This fixes the instruction for the cuda-architecture specific Docker build.
jkulhanek
pushed a commit
that referenced
this pull request
Mar 10, 2023
This fixes the instruction for the cuda-architecture specific Docker build.
chris838
pushed a commit
to chris838/nerfstudio
that referenced
this pull request
Apr 22, 2023
This fixes the instruction for the cuda-architecture specific Docker build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the instruction for the cuda-architecture specific Docker build.