NeusFacto #1654
Merged
NeusFacto #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanweber
reviewed
Apr 12, 2023
ethanweber
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Hey @pablovela5620, I made some changes, and feel free to merge if you agree with everything. LGTM!
|
Is there any documentation on how custom data can be pre-processed for use with the (now merged) NeusFacto? From what I could see it required different data pre-processing than e.g., nerfacto, could you confirm this? I created an issue #1732 so others may find it as well. |
chris838
pushed a commit
to chris838/nerfstudio
that referenced
this pull request
Apr 22, 2023
* add neus_facto method * fix missing pixsfm from video process * fix dev errors and small typos --------- Co-authored-by: Ethan Weber <[email protected]>
lucasthahn
pushed a commit
to tne-ai/nerfstudio
that referenced
this pull request
Apr 23, 2023
* add neus_facto method * fix missing pixsfm from video process * fix dev errors and small typos --------- Co-authored-by: Ethan Weber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added NeusFacto method, about 3x faster on per train iter basis (getting 50ms v.s. 150ms on baseline neus), with set defaults took around 15 minutes to train DTU scan 65. Tangentially also fixed
refine_pixsfmmissing fromvideoonns-process-dataTo download relevant data
to train on DTU scan 65 without monocular priors