return unscaled input in positional encoding #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tancik
approved these changes
Apr 17, 2023
|
@tancik I think the "Viewer Build and Deploy. / Build (pull_request)" test just failed (doubt this PR is causing it). In either case I don't think that I'm able to merge this PR myself |
|
Re-ran the tests, they pass now. |
chris838
pushed a commit
to chris838/nerfstudio
that referenced
this pull request
Apr 22, 2023
* return unscaled input in positional encoding * Update encodings.py
lucasthahn
pushed a commit
to tne-ai/nerfstudio
that referenced
this pull request
Apr 23, 2023
* return unscaled input in positional encoding * Update encodings.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the [0, 1] in_tensor is getting multiplied to [0, 2pi], and then being returned in that range instead of being returned unmodified