Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for k-planes add-on #1935

Merged
merged 4 commits into from
May 17, 2023
Merged

Conversation

Giodiro
Copy link
Contributor

@Giodiro Giodiro commented May 16, 2023

Hi! Finally, the docs for the k-planes add-on.
Hope the page is clear, but let me know if you have any doubts!

@tancik
Copy link
Contributor

tancik commented May 16, 2023

The instructions were updated a little in the past few days, there are now two more files that need to be updated, https://docs.nerf.studio/en/latest/nerfology/methods/index.html#adding-your-own-method

docs/nerfology/methods/index.md Outdated Show resolved Hide resolved
docs/nerfology/methods/kplanes.md Outdated Show resolved Hide resolved
docs/nerfology/methods/kplanes.md Outdated Show resolved Hide resolved
docs/nerfology/methods/kplanes.md Show resolved Hide resolved
@Giodiro
Copy link
Contributor Author

Giodiro commented May 17, 2023

sorry I totally missed the new requirements.. Should be fixed now!

Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding, cool project!

@tancik tancik merged commit be29197 into nerfstudio-project:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants