-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metashape_utils.py #2011
Conversation
Changed the ValueError message when using a camera.xml that contains multiple sensors. Per-frame intrinsics can be defined, the previous message said that they were not supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct to me!
I don't understand: the previous message was correct, and it was triggered only when using several camera_model values in the metashape project (eg fisheye + perspective). The limitation does not come from this utility but from nerfstudio itself, see here: "Per-frame |
@henrypearce4D @brentyi I think this should be reverted, as the new message is more confusing. |
Yeah, on a re-read the original error message makes sense. @henrypearce4D can you comment/confirm? |
@brentyi -
|
@henrypearce4D that sounds reasonable to me! |
This reverts commit 293d8f3.
Reverted back to the original error message with some extra clarification added. cc #2011
Changed the ValueError message when using a camera.xml that contains multiple sensors. Per-frame intrinsics can be defined, the previous message said that they were not supported.