Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PixelSampler Fixes #2298

Merged
merged 31 commits into from
Aug 4, 2023
Merged

PixelSampler Fixes #2298

merged 31 commits into from
Aug 4, 2023

Conversation

AdamRashid96
Copy link
Contributor

  • Fixed a bug where if someone specified a patch size with a Pixel Sampler other than PatchPixelSampler it would default to PatchPixelSampler
  • Added instructions to the NotImplementedError if you try to use a mask with PatchPixelSampler or PairPixelSampler

AdamRashid96 and others added 29 commits June 12, 2023 19:07
@AdamRashid96
monodepth implemented
1dc246c
@AdamRashid96
device
3d4361b
@AdamRashid96
pair pixel sampler
0fe3f53
@AdamRashid96
docstring
f7f038f
@AdamRashid96
removing unused imports
d855792
@AdamRashid96
fix bugs
5df7c95
@AdamRashid96
cache in cache dir, no longer edit json file
9c3dcbb
@AdamRashid96
moving to depth nerfacto
a617dfa
@AdamRashid96
fixed bug using median depth by accident
2d1366e
@AdamRashid96
removing depthdataset from nerfacto
293a201
@AdamRashid96
added pixelsamplerconfig
bcf10ed
@AdamRashid96
added equirectangular warning back
0e2edd9
@AdamRashid96
bug fix
7130b34
@AdamRashid96
delete sample_config.py + small fixes
ad15e0b
@tancik
Merge branch 'main' into main
f9dcb47
@ethanweber
Merge branch 'main' into AdamRashid96/main
f115dc7
@ethanweber
rename to pixel_sampler
aaeee72
@ethanweber
cleaning
25879e9
@ethanweber
test
c6cc0dd
@ethanweber
passing num_rays_per_batch properly
20f2575
@ethanweber
fixed transforms typo
daad810
@ethanweber
renaming in nerfacto
d963a9a
@AdamRashid96
remove depth files from test data
64ca002
@ethanweber
Merge branch 'main' into monodepth_regularization
b3e3e72
@AdamRashid96
removed defaulting to base pixel sampler with mask
a2f7599
@AdamRashid96
Merge branch 'monodepth_regularization' of https://github.com/nerfstu…
8a1aaaa 
…dio-project/nerfstudio into monodepth_regularization
@AdamRashid96
adding patch_size back
ffb221a
@AdamRashid96
Warning for notimplemented error and patch_size fix
e40786b
@AdamRashid96
Merge branch 'main' into monodepth_regularization
745d2b1
ethanweber
ethanweber reviewed Aug 3, 2023
View reviewed changes
nerfstudio/data/datamanagers/base_datamanager.py Outdated Show resolved Hide resolved
nerfstudio/data/pixel_samplers.py Outdated Show resolved Hide resolved
nerfstudio/data/pixel_samplers.py Outdated Show resolved Hide resolved
@ethanweber
Copy link
Collaborator

LGTM!

@ethanweber ethanweber merged commit 7e90cb7 into main Aug 4, 2023
@ethanweber ethanweber deleted the monodepth_regularization branch August 4, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanweber ethanweber ethanweber left review comments

@kerrj kerrj kerrj left review comments

@machenmusik machenmusik machenmusik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AdamRashid96 @ethanweber @machenmusik @kerrj @tancik