-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow colmap parser to load 3D points #2408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @jkulhanek, very useful. |
@jkulhanek, can you clarify what is the meaning of "points3D_num_points"? I think the naming might be a bit misleading, if my understanding is correct. |
I agree it is misleading. The meaning is the number of 2D points (number of images) the 3D point is matched to. Should I rename it to something like |
Thanks, yes. Is there a way to also get a full list of the image IDs that have the corresponding 2d points that correspond to the 3d point in question? From what I see, this p.image_ids just gives the number of point correspondences, which in itself is kind of useful (for example getting rid of poorly corresponding points) but it would be missing the exact image ids that these correspondences can be found in. I do not have much knowledge with colmap, so I am not sure if this is a feature or not. But I think renaming to points3D_num_2d_correspondences or similar would be very clear to me at least for now. |
Shouldn't p.image_ids contain the actual image IDs, not their number? |
I am not entirely sure, I read this page: https://colmap.github.io/format.html and they have some information about a list of image_ids and 2d point indexes for a single 3D point. Here is something similar in pycolmap: https://github.com/colmap/colmap/blob/main/scripts/python/read_write_model.py#L327. Again, I do not have much experience with colmap, so I am uncertain what this really means. Let me know if you can clarify my doubts. |
I believe |
Thanks, the naming just has me confused :D maybe we can rename everything to be consistent with pycolmap code then. |
Currently, p.image_ids is |
I think |
This PR adds an option to the colmap parser, which allows it to load 3D points. These points can be used in methods like tetra-nerf or Gaussian splatting.