Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch spiral rendering w/ parallel datamanager #2637

Merged
merged 16 commits into from
Nov 30, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion nerfstudio/scripts/render.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@
VanillaDataManager,
VanillaDataManagerConfig,
)
from nerfstudio.data.datamanagers.parallel_datamanager import ParallelDataManager
from nerfstudio.data.datamanagers.random_cameras_datamanager import (
RandomCamerasDataManager,
)
from nerfstudio.data.datasets.base_dataset import Dataset
from nerfstudio.data.scene_box import OrientedBox
from nerfstudio.data.utils.dataloaders import FixedIndicesEvalDataloader
Expand Down Expand Up @@ -666,7 +670,14 @@ def main(self) -> None:

install_checks.check_ffmpeg_installed()

assert isinstance(pipeline.datamanager, VanillaDataManager)
assert isinstance(
pipeline.datamanager,
(
VanillaDataManager,
ParallelDataManager,
RandomCamerasDataManager,
),
)
steps = int(self.frame_rate * self.seconds)
camera_start = pipeline.datamanager.eval_dataloader.get_camera(image_idx=0).flatten()
camera_path = get_spiral_path(camera_start, steps=steps, radius=self.radius)
Expand Down
Loading