Add --no-cache-dir option to pip install in Dockerfile #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb-ye
reviewed
Jan 12, 2024
Dockerfile
Outdated
| @@ -96,7 +96,7 @@ RUN git clone --branch 3.8 https://github.com/colmap/colmap.git --single-branch | |||
| mkdir build && \ | |||
| cd build && \ | |||
| cmake .. -DCUDA_ENABLED=ON \ | |||
| -DCMAKE_CUDA_ARCHITECTURES=${CUDA_ARCHITECTURES} && \ | |||
| torch==2.0.1+cu${CUDA_VER} \ | ||
| torchvision==0.15.2+cu${CUDA_VER} \ | ||
| --extra-index-url https://download.pytorch.org/whl/cu${CUDA_VER} |
Thank you @jb-ye for your advice. I have rebased my changes on top of the latest commit and fixed the indent issues. |
|
LGTM |
brentyi
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
--no-cache-diroption to thepip installcommand in theDockerfile. By including this option, the cache during Python package installation is disabled, resulting in a significant reduction (approximately 3.2GB) in disk usage duringdocker build.Without this option, the Docker image would contain the following cache, which is unnecessary:
du -sh /home/user/.cache/pip # 3.2G /home/user/.cache/pip