Use packaging for colmap version #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chungmin99
changed the title
ethanweber
reviewed
Jan 24, 2024
| CONSOLE.print(f"[bold red]Could not find COLMAP version. Using default {default_version}") | ||
| default_version = Version(str(default_version)) |
There was a problem hiding this comment.
I think this could lead to possible issues since the arg is overwritten. I suggest we type default_version as a string in the default arg and then skip to return Version(default_version) without having an intermediate copy or string conversion.
There was a problem hiding this comment.
Should be addressed in the latest commit!
ArpegorPSGH
pushed a commit
to ArpegorPSGH/nerfstudio
that referenced
this pull request
Jun 22, 2024
* Use packaging.version for colmap version * Run ruff * Change default_version to str type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the way we check the version for
colmapcommand.Using
Versionobjects frompackaging.versionshould be more stable than using float comparisons (3.7, 3.8, ...), which might break when the version cannot be represented as a float (e.g., 3.9.1).