-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support COLMAP reconstructions with non-flat image dirs #3006
Support COLMAP reconstructions with non-flat image dirs #3006
Conversation
@zacstewart Could you describe how you test this PR in step-by-step commands? My understanding is the change should support both single folder and multiple subfolder colmap project. Also what's the relation of this PR with #2976? |
7cbc71a
to
49a8577
Compare
@jb-ye Given you have a colmap reconstruction that has subdirectories in its images directory, there are no more steps than usual. This PR only effects how Do you need me to help prepare a small test dataset to demonstrate it? I can do so but I'll need a week before I can get to it. #2976 is an orthogonal issue. Colmap allows you to build reconstructions from homogeneous camera images, but In my case, I already have a colmap reconstruction that I built myself, outside of nerfstudio. It required special care to produce because the scene is very symmetrical and images tended to mis-register. Nerfstudio's internal invocation of colmap would not be able to reproduce it. |
The code was previously looking for the file.name, which drops all directory information from the path. Instead, we want to get the file path relative to the data dir, which will only drop parts of the path above the data dir, allowing us to recurse into subdirectories within the images dir
49a8577
to
1dff8c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is a low risk change and bring clear benefits.
…roject#3006) * Support COLMAP reconstructions with nested image dirs The code was previously looking for the file.name, which drops all directory information from the path. Instead, we want to get the file path relative to the data dir, which will only drop parts of the path above the data dir, allowing us to recurse into subdirectories within the images dir * Adhere to style guidelines * Add testcase to cover image dirs with subdirs
The code was previously looking for the file.name, which drops all directory information from the path. Instead, we want to get the file path relative to the data dir, which will only drop parts of the path above the data dir, allowing us to recurse into subdirectories within the images dir
For example, you can use COLMAP reconstructions that were built using multiple captures and have an images directory structured like this: