-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support splatfacto training for metashape exports #3122
Conversation
@simonbethke Could you try this PR and see if it works? I manually tested your dataset, and it seems fine. |
Yea, I will test it |
Okay, i tested a little bit. The happy path works!! The unhappy paths are rather bad. Not worse than the average quality but when taking that as benchmark it will stay bad forever :D
|
I know handling unhappy paths is tideous and no fun. If you like, just ignore what I wrote about them. |
For the stack trace verbosity, maybe we can add |
Yes, I sent out a new revision. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @simonbethke @jb-ye!
Thank you both for your help! |
Regarding this PR: |
@simonbethke Could you start a new issue and provide sample data there? |
test commands: