Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in SplatfactoModel when sh_degree is zero the color is not with sigmoid #3207

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Fix bug in SplatfactoModel when sh_degree is zero the color is not with sigmoid #3207

merged 3 commits into from
Jun 10, 2024

Conversation

liruilong940607
Copy link
Contributor

Fix

@liruilong940607 liruilong940607 enabled auto-merge (squash) June 10, 2024 15:25
@liruilong940607 liruilong940607 mentioned this pull request Jun 10, 2024
Merged
@liruilong940607 liruilong940607 merged commit 4b61cb9 into main Jun 10, 2024
2 checks passed
@liruilong940607 liruilong940607 deleted the gsplat-fix branch June 10, 2024 20:39
@bchretien
Copy link

@liruilong940607 I just ran a test and had to use colors_crop = torch.sigmoid(colors_crop)[:, 0, :] to avoid asserts in gsplat (without this, colors_crop.shape = [N, 1, 3]).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentyi brentyi brentyi approved these changes

@jb-ye jb-ye Awaiting requested review from jb-ye

@kerrj kerrj Awaiting requested review from kerrj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liruilong940607 @bchretien @brentyi