Add eval data to image_rename_map #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, in the core Tests, I got an error saying
However, I have not modified this file. Could you have a look what's happening? |
jb-ye
reviewed
Aug 30, 2024
| @@ -85,11 +88,11 @@ def main(self) -> None: | |||
| same_dimensions=self.same_dimensions, | |||
| keep_image_dir=True, | |||
| ) | |||
| image_rename_map_paths.update(eval_image_rename_map_paths) | |||
| image_rename_map_eval = dict( | |||
There was a problem hiding this comment.
just to follow the name convention, could we rename it to eval_image_rename_map?
jb-ye
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to run COLMAP with both training images and eval images but had an error message saying that
I spent some time and found that in
images_to_nerfstudio_dataset.pyfile (line 90-92), only train image folder (self.data) is in the relative_to(), whileimage_rename_map_pathscontains both train and test images.Therefore, I have tried to create a
image_rename_map_evalfor self.eval_data and update theimage_rename_mapwith it. Now the COLMAP can successfully run with both train and test dataset.