Allow for the firmware file size limit to be configurable #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshk
force-pushed
the
configurable-firmware-file-upload-size-limit
branch
from
e70711d to
4d68c7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the firmware file size upload limit to be adjusted via runtime env var.
Its a partial fix for file upload limits, as
Firmwares.create_firmware/3has a repo transaction limit of 30 secs, and the upload to s3 also has a 30 sec limit.I'd also like this to be configurable per org, such that free users can only upload smaller firmware sizes, but thats for a different discussion.