Add secp256r1 support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tests for secp256r1 fix secp256r1 test create separated auth programs remove lazy static remove verbose outputs, add more comments add docs for secp256r1
XuJiandong
requested changes
Aug 15, 2023
XuJiandong
requested changes
Aug 22, 2023
c/secp256r1.h
Outdated
| 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, | ||
| 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, | ||
| 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01}; | ||
| MUST_HAVE(aff_buf_len == affine_buffer_size); |
There was a problem hiding this comment.
Add a failed test case to trigger MUST_HAVE
There was a problem hiding this comment.
The aff_buf_len is actually set from
Line 34 in f9d096e
aff_buf_len is always SECP256R1_PUBKEY_SIZE. I refactor the code to return an error code instead of using MUST_HAVE. The functionailty of MUST_HAVE is been checked by manually flipping the condition here Line 96 in f9d096e
contrun
force-pushed
the
secp256r1
branch
2 times, most recently
from
10410f0 to
c41c999
Compare
XuJiandong
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.