Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace ckb-standalone-types with ckb-gen-types #71

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

EthanYuan
Copy link
Contributor

@EthanYuan EthanYuan commented Aug 28, 2023

Since ckb-gen-types (which supports no-std) has been separated from ckb-types, it's possible to replace ckb-standalone-types with it. This refactoring makes future maintenance more consistent.

This refactoring is essentially painless, requiring only minor modifications to the Cargo.toml file.

@EthanYuan EthanYuan marked this pull request as ready for review December 20, 2023 09:05
@quake quake merged commit c0cb2e1 into nervosnetwork:master Jan 2, 2024
2 checks passed
@xcshuan
Copy link

xcshuan commented Jan 3, 2024

There are some methods that do not exist in ckb-gen-types, such as converting Byte32 to [u8;32] through unpack.

@EthanYuan
Copy link
Contributor Author

There are some methods that do not exist in ckb-gen-types, such as converting Byte32 to [u8;32] through unpack.

Indeed ckb-standalone-types has some forks. I'll check again to add those to ckb-gen-types.
Thanks for pointing that out.

@quake
Copy link
Member

quake commented Jan 3, 2024

There are some methods that do not exist in ckb-gen-types, such as converting Byte32 to [u8;32] through unpack.

we are going to merge this PR: nervosnetwork/molecule#80

you may use into instead of unpack after a new release version of molecule is out.

foo.byte32([u8; 32].into())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants