perf: cache system cell for resolve deps #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
force-pushed
the
op-resolve-dep
branch
from
073145a to
e72ebc7
Compare
|
benchmark |
Benchmark Result
|
|
Please add PR description:
|
doitian
reviewed
Apr 14, 2020
util/types/src/core/cell.rs
Outdated
| @@ -424,16 +446,27 @@ pub fn resolve_transaction<CP: CellProvider, HC: HeaderChecker, S: BuildHasher>( | |||
| } | |||
| } | |||
|
|
|||
| let system_cell = SYSTEM_CELL.get().expect("SYSTEM_CELL is not initialized"); | |||
There was a problem hiding this comment.
I think a more elegant solution is creating a wrapper around the resolver, like:
struct<F> CellProviderWithSystemCellCache {
system_cell: SystemCell,
inner: F,
}
There was a problem hiding this comment.
This PR is a draft for bench, I will improve it later.
But I think CellProvider is also a bad idea, this cache is for dep, not input.
zhangsoledad
changed the title
![nervos-bot[bot]](https://avatars.githubusercontent.com/in/22976?s=60&v=4){kind=small}
zhangsoledad
force-pushed
the
op-resolve-dep
branch
from
e72ebc7 to
0c86b9f
Compare
|
benchmark |
Benchmark Result
|
zhangsoledad
force-pushed
the
op-resolve-dep
branch
from
0c86b9f to
4903071
Compare
zhangsoledad
changed the title
nervos-bot
bot
dismissed
their stale review
Unhold as requested by @zhangsoledad.
quake
approved these changes
Apr 21, 2020
driftluo
approved these changes
Apr 21, 2020
|
bors r+ |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to optimize transaction resolve.
Currently, transaction resolve is inefficient, cause system-cell is uncached, every transaction depends on system cell will read system-cell from disk repeatedly. this PR proposal a system-cell cache implementation.