Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should use an empty peer store when failed to load data from file #2063

Merged
merged 1 commit into from
May 11, 2020
Merged

fix: should use an empty peer store when failed to load data from file #2063

merged 1 commit into from
May 11, 2020

Conversation

quake
Copy link
Member

@quake quake commented May 10, 2020 •
edited
Loading

PeerStore#load_from_dir should return an empty peer store instead of panic when failed to load data from file system.

@quake quake requested review from a team and doitian May 10, 2020 09:41
doitian
doitian requested changes May 10, 2020
View reviewed changes
Copy link
Member

@doitian doitian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case to cover this change

@quake quake force-pushed the quake/fix-empty-peerstore branch from 4ad1ff1 to 7b3a731 Compare May 10, 2020 11:50
@doitian
Copy link
Member

doitian commented May 11, 2020

bors r=doitian,keroro520,driftluo

@bors
Copy link
Contributor

bors bot commented May 11, 2020

Build succeeded:

  • continuous-integration/travis-ci/push

@bors bors bot merged commit b8a4743 into develop May 11, 2020
@bors bors bot deleted the quake/fix-empty-peerstore branch May 11, 2020 09:02
@quake quake restored the quake/fix-empty-peerstore branch May 11, 2020 09:10
@quake quake deleted the quake/fix-empty-peerstore branch May 11, 2020 09:17
@quake quake mentioned this pull request May 11, 2020
Merged
bors bot added a commit that referenced this pull request May 12, 2020
@bors @quake
Merge #2066
29996d7 
2066: [backport] #2063 fix: should use an empty peer store when failed to load data from file r=TheWaWaR a=quake

Backport #2063 

Closes #2065

Co-authored-by: quake <[email protected]>
doitian added a commit that referenced this pull request May 12, 2020
@doitian
Merge pull request #2066 from nervosnetwork/backport/2063
eb3b9ce 
[backport] #2063 fix: should use an empty peer store when failed to load data from file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driftluo driftluo driftluo approved these changes

@keroro520 keroro520 keroro520 approved these changes

@doitian doitian doitian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quake @doitian @keroro520 @driftluo