Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document errors #2456

Merged
merged 1 commit into from
Dec 30, 2020
Merged

docs: document errors #2456

merged 1 commit into from
Dec 30, 2020

Conversation

keroro520
Copy link
Contributor

No description provided.

@keroro520 keroro520 requested review from yangby-cryptape and a team December 22, 2020 08:12
@keroro520 keroro520 requested a review from a team December 22, 2020 08:12
yangby-cryptape
yangby-cryptape requested changes Dec 22, 2020
View reviewed changes
error/src/util.rs Outdated Show resolved Hide resolved
error/src/util.rs Outdated Show resolved Hide resolved
error/src/util.rs Outdated Show resolved Hide resolved
error/src/util.rs Outdated Show resolved Hide resolved
error/Cargo.toml Outdated Show resolved Hide resolved
util/types/src/core/error.rs Outdated Show resolved Hide resolved
util/dao/src/lib.rs Show resolved Hide resolved
@keroro520
Copy link
Contributor Author

@yangby-cryptape Thanks for your comments. Most of the suggestions applied, except for the long line.

There are so many long comments in this PR and original code; I would like to ignore this issue for the moment and unify them via rustfmt comment_width later.

@doitian
Copy link
Member

doitian commented Dec 30, 2020

bors r=doitian,yangby-cryptape

@doitian doitian added the t:doc Type: Documentation label Dec 30, 2020
@bors
Copy link
Contributor

bors bot commented Dec 30, 2020

Build succeeded:

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 4a5e8a2 into nervosnetwork:develop Dec 30, 2020
@keroro520 keroro520 mentioned this pull request Dec 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangby-cryptape yangby-cryptape yangby-cryptape approved these changes

@doitian doitian doitian approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
t:doc Type: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keroro520 @doitian @yangby-cryptape