chore: remove deps cycle #3929
Closed
chore: remove deps cycle #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyukang
force-pushed
the
yukang/fix-dep-cycle
branch
from
aba2d2c to
edae6a8
Compare
chenyukang
commented
Apr 11, 2023
| @@ -59,7 +59,7 @@ case $GITHUB_WORKFLOW in | |||
| make check-whitespaces | |||
| make check-dirty-rpc-doc | |||
| make check-dirty-hashes-toml | |||
| devtools/ci/check-cyclic-dependencies.py | |||
| devtools/ci/check-cyclic-dependencies.py --dev | |||
There was a problem hiding this comment.
we didn't check the exit code of this script, should we fix it?
|
A good way to understand the whole repo. |
chenyukang
force-pushed
the
yukang/fix-dep-cycle
branch
from
edae6a8 to
3048cc2
Compare
eval-exec
reviewed
Apr 11, 2023
| @@ -36,7 +36,6 @@ ckb-reward-calculator = { path = "../util/reward-calculator", version = "= 0.110 | |||
| ckb-tx-pool = { path = "../tx-pool", version = "= 0.110.0-pre", features = ["internal"] } | |||
| ckb-jsonrpc-types = { path = "../util/jsonrpc-types", version = "= 0.110.0-pre" } | |||
| ckb-network = { path = "../network", version = "= 0.110.0-pre" } | |||
| ckb-launcher = { path = "../util/launcher", version = "= 0.110.0-pre" } | |||
There was a problem hiding this comment.
I don't think we should remove ckb-launcher from [dev-dependencies], because there are some unit tests in ckb-chain need ckb-launcher.
quake
requested changes
Apr 11, 2023
Yes, I can reproduce it in my local env. |
|
According to rust-lang/rust-analyzer#14167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Remove deps cycle in Cargo.toml.
Problem Summary:
rust-analyzeris blaming for it:And if we remove the deps cycle, we could use
cargo depsto visualize deps graph.devtools/ci/check-cyclic-dependencies.pyin CI is not working, do we need to enable it to check the dep order name?Check List
Tests
Side effects
Release note