refactor: use BlockNumberAndHash in get_ancestor #3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
requested review from
doitian,
zhangsoledad and
eval-exec
and removed request for
a team
eval-exec
approved these changes
Apr 23, 2023
quake
force-pushed
the
quake/optimize-get-ancestor
branch
from
24d1c7d to
087e742
Compare
zhangsoledad
approved these changes
Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Same purpose as #3952, this PR replaced
HeaderViewwithBlockNumberAndHashin fngen_ancestor, also removed the mutable requirement since it's only used in unit test.Check List
Tests
Release note