Extend the hardcoded assume_valid_target to an array.
#4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing and doing a self-review... |
eval-exec
added
m:sync
eval-exec
changed the title
assume_valid_target to an array.
eval-exec
force-pushed
the
exec/asume-valid-target-array
branch
2 times, most recently
from
6e92790 to
6355923
Compare
eval-exec
changed the title
assume_valid_target to an array.assume_valid_target to an array.
eval-exec
changed the title
assume_valid_target to an array.assume_valid_target to an array.
eval-exec
force-pushed
the
exec/asume-valid-target-array
branch
5 times, most recently
from
8b59dbc to
93b6245
Compare
eval-exec
changed the title
assume_valid_target to an array.assume_valid_target to an array.
eval-exec
requested review from
doitian,
chenyukang,
zhangsoledad,
driftluo and
yangby-cryptape
eval-exec
force-pushed
the
exec/asume-valid-target-array
branch
from
93b6245 to
423720c
Compare
eval-exec
force-pushed
the
exec/asume-valid-target-array
branch
from
423720c to
123eb75
Compare
eval-exec
force-pushed
the
exec/asume-valid-target-array
branch
2 times, most recently
from
960bf1c to
24b975b
Compare
eval-exec
force-pushed
the
exec/asume-valid-target-array
branch
from
caa2a6a to
c955861
Compare
…onential growth target to lastest_assume_valid_target
Signed-off-by: Eval EXEC <[email protected]>
Signed-off-by: Eval EXEC <[email protected]>
eval-exec
force-pushed
the
exec/asume-valid-target-array
branch
2 times, most recently
from
a5225d5 to
a02db5e
Compare
Signed-off-by: Eval EXEC <[email protected]>
eval-exec
force-pushed
the
exec/asume-valid-target-array
branch
from
a02db5e to
2a98841
Compare
quake
approved these changes
Jan 9, 2025
|
@doitian @quake @zhangsoledad How about adding this PR to the release pipeline of |
zhangsoledad
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Resolve #4518.
Follow up #4254, this PR want to hardcode an array of default_valid_targets for ckb-sync.
What is changed and how it works?
This PR aims to replace the hardcoded DEFAULT_ASSUME_VALID_TARGET in CKB with an array. After CKB starts up, the header sync process currently takes over an hour to sync headers and search for the hardcoded target within them.
By changing this target to an array, which contains selected blocks from the main chain with exponentially increasing heights, we can improve the process. As soon as the header sync reaches the first block, it can immediately start using the first target in the array as the new synchronization target, allowing for more efficient block syncing after CKB startup.
What's Changed:
Related changes
Check List
Tests
Side effects
Release note