fix: Genesis block should be scanned when next scan range #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starts from block #1
This bug is very interesting.
The block
queuescans a window of blocks in batch. It remembers the last scanned blockN, and starts fromN + 1for next round.Nwas initialized as-1then the first round would start from genesis block.But initially it also reads another DB saved number representing last block number. When Neuron launches without any wallets, that number will be zero and persisted.
Then when a wallet gets imported the queue scans from
1, not genesis block!Yet to see if this guard fixes completely. It seems too difficult to change the scan range and remove the
N + 1operation, though.