feat: sync by indexer RPCs #863
Conversation
classicalliu
commented
Aug 13, 2019
•
classicalliu
commented
- impl sync by indexer RPCs
- auto use indexer mode when indexer RPCs is available
|
Holding this to prevent from merging while we review and test this feature. |
![nervos-bot[bot]](https://avatars.githubusercontent.com/in/22976?s=60&v=4){kind=small}
| @@ -55,6 +55,16 @@ export default class GetBlocks { | |||
| return block | |||
| } | |||
|
|
|||
| public getTransaction = async (hash: string): Promise<CKBComponents.TransactionWithStatus> => { | |||
There was a problem hiding this comment.
should getTransaction be placed in a separate file?
There was a problem hiding this comment.
No need, it's block info too.
|
|
||
| if ( | ||
| txPoint && | ||
| (BigInt(txPoint.blockNumber) >= startBlockNumber || this.tipBlockNumber - BigInt(txPoint.blockNumber) < 1000) |
There was a problem hiding this comment.
Is it possible to extract this expression into a method?
There was a problem hiding this comment.
No need, only use once.
| await this.indexLockHashes(lockHashes) | ||
| this.indexed = true | ||
| } | ||
| const minBlockNumber = await this.getCurrentBlockNumber(lockHashes) |
There was a problem hiding this comment.
What is the difference between currentBlockNumber and minBlockNumber?
There was a problem hiding this comment.
minBlockNumber means the min block number in get_lock_hash_index_states of all lock hashes.
| @@ -48,4 +48,20 @@ export default class Utils { | |||
| } | |||
| return result | |||
| } | |||
|
|
|||
| public static min = (array: bigint[]): bigint | undefined => { | |||
There was a problem hiding this comment.
Why would a numeric operation belong to sync/utils?
There was a problem hiding this comment.
Utility methods of sync module.
| ConsumedBy = 'consumedBy', | ||
| } | ||
|
|
||
| export default class Queue { |
There was a problem hiding this comment.
While I understand we have different folders - to some extend they act like namespaces, having multiple Queue classes worries me that it could confuse reading and understanding our design and implementation.
There was a problem hiding this comment.
How about IndexerQueue
There was a problem hiding this comment.
That's better. We have two queue implementations for two different modules, then we name them differently for clarification. Please do so.
| // stop all blocks service | ||
| if (blockListener) { | ||
| await blockListener.stopAndWait() | ||
| export const testIndexer = async (url: string): Promise<boolean> => { |
There was a problem hiding this comment.
It'd be more clearer to name it such as isIndexerEnabled or something like that.
Co-Authored-By: James Chen <[email protected]>
