FLK-1037 - Changes made for Lab Exercises 3 and 4 #2
Conversation
| @@ -41,6 +43,9 @@ public class LongRidesUnitTest extends LongRidesTestBase { | |||
|
|
|||
| private KeyedOneInputStreamOperatorTestHarness<Long, TaxiRide, Long> harness; | |||
|
|
|||
| @Rule | |||
| public ExpectedException exceptionRule = ExpectedException.none(); | |||
There was a problem hiding this comment.
- What is it? Purpose.
- Why it's public?
There was a problem hiding this comment.
This is to check if the expected exception is thrown with a expected message. It doesn't need to be public. should be private
There was a problem hiding this comment.
Rewritten the Junit to handle exception using Junit-5
| @@ -110,6 +115,16 @@ public void shouldAlertWithStartFirst() throws Exception { | |||
| assertThat(resultingRideId()).isEqualTo(rideStarted.rideId); | |||
| } | |||
|
|
|||
| @Test | |||
| public void shouldThrowExceptionWhenIsStartFalse() throws Exception { | |||
| exceptionRule.expect(LongRidesException.class); | |||
There was a problem hiding this comment.
Sorry, what we are checking here?
As I see you introduced variable
@Rule
public ExpectedException exceptionRule = ExpectedException.none();
a now just do this, what is the reason of it?
There was a problem hiding this comment.
checking if the method is throwing an exception when startTime is not available in the end event
There was a problem hiding this comment.
Please use proper methods for it
https://github.com/junit-team/junit5/blob/main/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertThrows.java#L41
thanks
There was a problem hiding this comment.
Rewritten the Junit to handle exception using Junit-5
No description provided.