FLK-994 Module 1 Lab code #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-hp
suggested changes
Apr 26, 2023
There was a problem hiding this comment.
In general PR looks good.
But.
It cannot be based on master branch which is now upgraded to Flink 1.16
Please follow instructions
https://ness-nde.atlassian.net/wiki/spaces/RSH/pages/3498115980/Flink+Training+Home
And create your branch from correct Branch
|
Created a new PR as per Pavel comments |
|
Attached the new PR request created in fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes changed 4 labs of module1 and ran all the test cases.