Updating charts with new npm scores #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahl_targets/notebooks/npm_annex.py
Outdated
| / store_data_hfss["weight_prod"].sum() | ||
| ) | ||
|
|
||
| hfss_shares_none = ( |
There was a problem hiding this comment.
I think that this is not very interpretable as it's just giving the sample average (rather than the population). By unweighted we normally mean the share calculated on the unique set of products and I think this is actually what the figure in the appendix refers to.
There was a problem hiding this comment.
@ElenaMariani I think I just need to remove this variable as its not used in the document I think I had created it previously just to sense check the values against some in a spreadsheet and so copied it over to this file.
Its a good point on what the appendix is referring to (I think I did have the unweighted mean also in another script but didn't copy it over here). Lets discuss on our call later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
npm_annexto create charts B, C and Y again with new NPM scores (names based on previous naming conventions). I have saved the outputs here. To note, for chart C, I have created two versions of the data and a png output. This is because Lauren wasn't able to produce the chart type in flourish and I think had to trace based on the png in the end. Have therefore added the image, the original data file format (products with NPM scores) and one grouped as percent share per NPM score (incase that might be easier for Husain to work with).