04 sentence classifier experimentation #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n with results of experimentation
lizgzil
commented
Jul 1, 2021
Makefile
Outdated
| @@ -11,7 +11,7 @@ endif | |||
| PROFILE = default | |||
| # Import env variables | |||
| include .env.shared | |||
| include .env | |||
| # include .env | |||
There was a problem hiding this comment.
@bishax When this wasn't commented out if I did make conda-create I would get the error
Makefile:14: .env: No such file or directory
make: *** No rule to make target `.env'. Stop
With it commented out things worked as I expected.
Is there a work around this/should I not be building the virtualenv this way?
There was a problem hiding this comment.
It's a bug in the cookiecutter that has since been fixed. Fix is to add this line...
It happens because .env is git ignored and so doesn't exist when a cookiecutter is cloned by someone else.
There was a problem hiding this comment.
Ah ha! Thanks so much, I'll add that instead of commenting out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #4
window_char_len = 50, n JDs = 10000, 25917 training data of sentences with skill entities in, test results: 'SKILL': 0.866)Best result:
I think the best results are between experiments 3 and 7. Although 3 has a better recall of the positive class, I think I will take forward the parameters in experiment 7 since they are only slightly worse in the recall of the positive class, and much better in the recall of the negative class.