fix: use a shared core module definition object

nestjs · Jan 21, 2025 · 9725471 · 9725471
1 parent 3f3e6b0
commit 9725471
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 25 deletions.
diff --git a/packages/bull/lib/bull.module.ts b/packages/bull/lib/bull.module.ts
@@ -28,6 +28,13 @@ import {
 
 @Module({})
 export class BullModule {
+  private static coreModuleDefinition = {
+    global: true,
+    module: BullModule,
+    imports: [DiscoveryModule],
+    providers: [BullExplorer, BullMetadataAccessor],
+  };
+
   /**
    * Registers a globally available configuration for all queues.
    *
@@ -127,7 +134,7 @@ export class BullModule {
     const queueOptionProviders = createQueueOptionProviders([].concat(options));
     return {
       module: BullModule,
-      imports: [BullModule.registerCore()],
+      imports: [BullModule.coreModuleDefinition],
       providers: [...queueOptionProviders, ...queueProviders],
       exports: queueProviders,
     };
@@ -148,7 +155,7 @@ export class BullModule {
       .reduce((a, b) => a.concat(b), []);
 
     return {
-      imports: imports.concat(BullModule.registerCore()),
+      imports: imports.concat(BullModule.coreModuleDefinition),
       module: BullModule,
       providers: [
         ...asyncQueueOptionsProviders,
@@ -264,15 +271,6 @@ export class BullModule {
     };
   }
 
-  private static registerCore() {
-    return {
-      global: true,
-      module: BullModule,
-      imports: [DiscoveryModule],
-      providers: [BullExplorer, BullMetadataAccessor],
-    };
-  }
-
   private static getUniqImports(
     options: Array<BullModuleAsyncOptions | SharedBullAsyncConfiguration>,
   ) {

diff --git a/packages/bullmq/lib/bull.module.ts b/packages/bullmq/lib/bull.module.ts
@@ -40,6 +40,13 @@ export class BullModule {
   private static _queueClass: Type = Queue;
   private static _flowProducerClass: Type = FlowProducer;
   private static _workerClass: Type = Worker;
+  private static coreModuleDefinition = {
+    global: true,
+    module: BullModule,
+    imports: [DiscoveryModule],
+    providers: [BullExplorer, BullMetadataAccessor, BullRegistrar],
+    exports: [BullRegistrar],
+  };
 
   /**
    * Class to be used to create Bull queues.
@@ -184,7 +191,7 @@ export class BullModule {
 
     return {
       module: BullModule,
-      imports: [BullModule.registerCore()],
+      imports: [BullModule.coreModuleDefinition],
       providers: [...queueOptionProviders, ...queueProviders],
       exports: queueProviders,
     };
@@ -210,7 +217,7 @@ export class BullModule {
       .reduce((a, b) => a.concat(b), []);
 
     return {
-      imports: imports.concat(BullModule.registerCore()),
+      imports: imports.concat(BullModule.coreModuleDefinition),
       module: BullModule,
       providers: [
         ...asyncQueueOptionsProviders,
@@ -301,7 +308,7 @@ export class BullModule {
 
     return {
       module: BullModule,
-      imports: [BullModule.registerCore()],
+      imports: [BullModule.coreModuleDefinition],
       providers: [...flowProducerOptionProviders, ...flowProducerProviders],
       exports: flowProducerProviders,
     };
@@ -324,7 +331,7 @@ export class BullModule {
       .reduce((a, b) => a.concat(b), []);
 
     return {
-      imports: imports.concat(BullModule.registerCore()),
+      imports: imports.concat(BullModule.coreModuleDefinition),
       module: BullModule,
       providers: [
         ...asyncFlowProducerOptionsProviders,
@@ -456,16 +463,6 @@ export class BullModule {
     };
   }
 
-  private static registerCore() {
-    return {
-      global: true,
-      module: BullModule,
-      imports: [DiscoveryModule],
-      providers: [BullExplorer, BullMetadataAccessor, BullRegistrar],
-      exports: [BullRegistrar],
-    };
-  }
-
   private static getUniqImports(
     options: Array<RegisterQueueAsyncOptions | SharedBullAsyncConfiguration>,
   ) {