Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2026 feat: nest build --all flag #2312

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

iliazeus
Copy link

@iliazeus iliazeus commented Sep 28, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

(checking the tests box since I don't see a way to add "high-level" tests for an Action, only for stuff in /lib)

(docs == commander option descriptions)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2026

What is the new behavior?

  • added an --all flag to nest build to build all projects in a monorepo
  • as a bonus: added an ability to specify several projects as nest build args (the --all flag was easier to implement this way :)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@iliazeus iliazeus marked this pull request as ready for review September 28, 2023 16:07
@iliazeus
Copy link
Author

The implementation has a bug and does not work right now. Can't find a way to put a PR back into draft mode.

@iliazeus iliazeus force-pushed the feature/2026/build-all branch from 342cab4 to d441d5c Compare September 28, 2023 16:39
@iliazeus
Copy link
Author

The bug should now be fixed. Tested on my local projects, seems good.

@fdundjer
Copy link

fdundjer commented Nov 9, 2023

Hi, is there any planned release date for this? We are looking for this functionality.

@jjunyjjuny
Copy link

Happy New Year everyone~

Is this work in progress? I am waiting for this feature to be released...

: getBuilder(configuration, commandOptions, appName);
let appNames: string[];
if (buildAll) {
appNames = [undefined!]; // always include the default project
Copy link
Member

@micalevisk micalevisk Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change this to be const appNames: string[] | undefined;

the undefined! looks hacky to me

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change that, but it requires to also change a lot of other APIs that do accept undefined to mean "default app", but do not declare that.

I was reluctant to do it, since it's a lot of changes, but if it's okay I'll change those to string | undefined.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this spot and all the APIs it trickles down to in f574cfd.

Haven't looked at other places that accept an appName - they may also need to be changed to explicitly allow undefined, but that would be outside of this PR's scope.

@iliazeus iliazeus force-pushed the feature/2026/build-all branch from 179f9c7 to f574cfd Compare January 11, 2024 13:03
@void-nick
Copy link

I'd like this feature too!!

@Ahmadh26
Copy link

any updates on this PR? :)

@fesoares
Copy link

please release this feature 🙏🏻

@jelical
Copy link

jelical commented Apr 21, 2024

Any updates on this? When it about to be released?

@SergioSuarezDev
Copy link

SergioSuarezDev commented Apr 24, 2024

super option! It is very good to be able to generate a single docker image with the entire project and then use it to init 2 or more services that share the same build

@ajfranzoia
Copy link

Waiting for this feature as well, I don't want to switch to Nx just because of this

@cetfu
Copy link

cetfu commented May 23, 2024

👀

3 similar comments
@alande-amorim
Copy link

👀

@lotusflare-shangfengliu
Copy link

👀

@System233
Copy link

👀

@AwesomeAdventure
Copy link

Hi @kamilmysliwiec,

Could you please release this PR? It will greatly help those who have a lot of projects in monorepo.

@iliazeus iliazeus force-pushed the feature/2026/build-all branch from f574cfd to aef1368 Compare September 9, 2024 09:01
@kamilmysliwiec kamilmysliwiec changed the base branch from master to next November 22, 2024 11:55
@kamilmysliwiec kamilmysliwiec merged commit d4746a1 into nestjs:next Nov 22, 2024
1 check passed
@kamilmysliwiec kamilmysliwiec added this to the 11.0.0 milestone Nov 22, 2024
@cetfu
Copy link

cetfu commented Nov 22, 2024

🎉

@kamilmysliwiec kamilmysliwiec mentioned this pull request Nov 22, 2024
3 tasks
@iliazeus iliazeus deleted the feature/2026/build-all branch November 22, 2024 21:51
@Redstoneguy129
Copy link

#2026

@Redstoneguy129
Copy link

This commit does not fulfill the requirements for the issue. Yes -all builds all microservices. However it does not do the same for start. Which other issues asking for has been closed for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.