Skip to content

Commit

Permalink
refactor: pick only one option attribute for test module
Browse files Browse the repository at this point in the history
  • Loading branch information
kamilmysliwiec committed Jan 20, 2025
1 parent 6254af7 commit 65cfe0c
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 10 deletions.
14 changes: 6 additions & 8 deletions packages/testing/test.ts
Original file line number Diff line number Diff line change
@@ -1,19 +1,17 @@
import { ModuleMetadata } from '@nestjs/common/interfaces/modules/module-metadata.interface';
import { MetadataScanner } from '@nestjs/core/metadata-scanner';
import { TestingModuleBuilder } from './testing-module.builder';
import { NestApplicationContextOptions } from '@nestjs/common/interfaces/nest-application-context-options.interface';
import {
TestingModuleBuilder,
TestingModuleOptions,
} from './testing-module.builder';

export class Test {
private static readonly metadataScanner = new MetadataScanner();

public static createTestingModule(
metadata: ModuleMetadata,
contextOptions: NestApplicationContextOptions | undefined = undefined,
options?: TestingModuleOptions,
) {
return new TestingModuleBuilder(
this.metadataScanner,
metadata,
contextOptions,
);
return new TestingModuleBuilder(this.metadataScanner, metadata, options);
}
}
12 changes: 10 additions & 2 deletions packages/testing/testing-module.builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@ import { TestingInjector } from './testing-injector';
import { TestingInstanceLoader } from './testing-instance-loader';
import { TestingModule } from './testing-module';

/**
* @publicApi
*/
export type TestingModuleOptions = Pick<
NestApplicationContextOptions,
'moduleIdGeneratorAlgorithm'
>;

/**
* @publicApi
*/
Expand All @@ -41,9 +49,9 @@ export class TestingModuleBuilder {
constructor(
private readonly metadataScanner: MetadataScanner,
metadata: ModuleMetadata,
contextOptions: NestApplicationContextOptions | undefined = undefined,
options?: TestingModuleOptions,
) {
this.container = new NestContainer(this.applicationConfig, contextOptions);
this.container = new NestContainer(this.applicationConfig, options);
this.module = this.createModule(metadata);
}

Expand Down

0 comments on commit 65cfe0c

Please sign in to comment.