Add a description of the listen method to NestFastifyApplication

[grin0c]

Feature Request

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

I want to handle the fastify error when starting the app.

await app.listen(port, host, (err: Error) => {
    if (err) {
      logger.error(err)
      process.exit(1)
    }

    logger.info(`Application is listening on port ${host}:${port}.`, 'Main')
  })

If you write this now, typescript throws an error, so in INestApplication, the listen method is defined like this:

listen(port: number | string, callback?: () => void): Promise<any>;
listen(port: number | string, hostname: string, callback?: () => void): Promise<any>;

I suggest taking the annotation from https://github.com/fastify/fastify/blob/master/fastify.d.ts#L529-L537 and adding it to NestFastifyApplication

Teachability, Documentation, Adoption, Migration Strategy

What is the motivation / use case for changing the behavior?

[kamilmysliwiec]

Looks good. Would you like to create a PR for this?

[grin0c]

I will do

[kamilmysliwiec]

Fixed in 6.11.0

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.