Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fastify): added description of the listen method #3801

Merged
merged 2 commits into from
Jan 24, 2020
Merged

feat(fastify): added description of the listen method #3801

merged 2 commits into from
Jan 24, 2020

Conversation

grin0c
Copy link
Contributor

@grin0c grin0c commented Jan 11, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3786

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

coveralls commented Jan 11, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 11938

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.436%
Totals Coverage Status
Change from base Build 11846: 0.0%
Covered Lines: 4475
Relevant Lines: 4689
💛 - Coveralls

kamilmysliwiec
kamilmysliwiec reviewed Jan 13, 2020
View reviewed changes
packages/platform-fastify/interfaces/nest-fastify-application.interface.ts Outdated
* Starts the application.
* @returns A Promise that, when resolved, is a reference to the underlying HttpServer.
*/
listen(port: number, callback: NestFastifyListenCallback): Promise<any>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use an inline type (err: Error, address: string) => void instead of creating a dedicated file.

kamilmysliwiec
kamilmysliwiec reviewed Jan 13, 2020
View reviewed changes
packages/platform-fastify/interfaces/nest-fastify-application.interface.ts
address: string,
backlog: number,
callback: NestFastifyListenCallback,
): Promise<any>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing listen with 1 argument (just port and nothing else)

@kamilmysliwiec kamilmysliwiec added this to the 6.11.0 milestone Jan 24, 2020
@kamilmysliwiec kamilmysliwiec merged commit 7b864d3 into nestjs:master Jan 24, 2020
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kamilmysliwiec kamilmysliwiec kamilmysliwiec left review comments

Assignees
No one assigned
Labels
scope: platform status: wip ⚡️ type: enhancement 🐺
Projects
None yet
Milestone
6.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@grin0c @coveralls @kamilmysliwiec