Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email protected] has been deprecated, please upgrade to @fastify/cors@7 #9576

Closed
5 of 15 tasks
liaoliaots opened this issue May 13, 2022 · 1 comment
Closed
5 of 15 tasks

[email protected] has been deprecated, please upgrade to @fastify/cors@7 #9576

liaoliaots opened this issue May 13, 2022 · 1 comment
Labels
needs triage This issue has not been looked into

Comments

@liaoliaots
Copy link

liaoliaots commented May 13, 2022 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

Since version 6.1.0 of fastify-cors, it will throw a warning:

2022-05-13 22-21-34屏幕截图

index.js from [email protected]:

2022-05-13 22-26-12屏幕截图

Minimum reproduction code

unneeded

Steps to reproduce

  1. call enableCors() method on the Nest application object:
const app = await NestFactory.create<NestFastifyApplication>(AppModule, new FastifyAdapter());
app.enableCors();
await app.listen(3000);
  1. run npm run start:dev

Expected behavior

No Warning

Package

  • I don't know. Or some 3rd-party package
  • @nestjs/common
  • @nestjs/core
  • @nestjs/microservices
  • @nestjs/platform-express
  • @nestjs/platform-fastify
  • @nestjs/platform-socket.io
  • @nestjs/platform-ws
  • @nestjs/testing
  • @nestjs/websockets
  • Other (see below)

Other package

No response

NestJS version

8.4.5

Packages versions

2022-05-13 22-35-47屏幕截图

Node.js version

16.15.0 LTS

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

related PR #9540
@liaoliaots liaoliaots added the needs triage This issue has not been looked into label May 13, 2022
@micalevisk
Copy link
Member

this will be fixed by #9507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage This issue has not been looked into
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@micalevisk @kamilmysliwiec @liaoliaots