Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update fastify deps #9507

Merged
merged 6 commits into from
May 17, 2022
Merged

chore: update fastify deps #9507

merged 6 commits into from
May 17, 2022

Conversation

alexfriesen
Copy link
Contributor

@alexfriesen alexfriesen commented Apr 29, 2022 •
edited by kamilmysliwiec
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Fastify moved a lot of packages around and left the remaining ones with this deprecation message: [FST_MODULE_DEP_FASTIFY-STATIC] FastifyWarning.fastify-static: fastify-static has been deprecated. Use @fastify/[email protected] instead.

Issue Number: N/A

What is the new behavior?

No deprecation warning.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

micalevisk
micalevisk suggested changes Apr 30, 2022
View reviewed changes
Copy link
Member

@micalevisk micalevisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to touch the package-lock.json file as well, right?

@coveralls
Copy link

coveralls commented May 1, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3c383352-9712-4fbb-9dff-8619b4b888ee

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.044%
Totals Coverage Status
Change from base Build 0b7a2920-8444-444c-b2ff-50291f5d0d10: 0.0%
Covered Lines: 5763
Relevant Lines: 6128
💛 - Coveralls

@alexfriesen alexfriesen requested a review from micalevisk May 1, 2022 11:34
@alexfriesen
Copy link
Contributor Author

alexfriesen commented May 1, 2022 •
edited
Loading

I guess we need to touch the package-lock.json file as well, right?

Yes you are right, sorry about that. The package-lock files are updated as well

@flamewow
Copy link
Member

flamewow commented May 3, 2022

can you check platform-fastify/interfaces/external/* and sync if needed? I believe fastifyStaticOptions got updated

@alexfriesen alexfriesen requested a review from kamilmysliwiec May 4, 2022 19:04
@kamilmysliwiec kamilmysliwiec added this to the 9.0.0 milestone May 13, 2022
@micalevisk micalevisk mentioned this pull request May 13, 2022
Closed
15 tasks
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 9.0.0 May 17, 2022 11:22
@kamilmysliwiec kamilmysliwiec merged commit ddd95b8 into nestjs:9.0.0 May 17, 2022
@kamilmysliwiec kamilmysliwiec mentioned this pull request May 20, 2022
Merged
12 tasks
@Tony133 Tony133 mentioned this pull request Jun 10, 2022
Closed
12 tasks
@Tony133 Tony133 mentioned this pull request Jun 20, 2022
Closed
6 tasks
@AshakaE AshakaE mentioned this pull request Sep 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flamewow flamewow flamewow approved these changes

@Tony133 Tony133 Tony133 approved these changes

@micalevisk micalevisk micalevisk approved these changes

@kamilmysliwiec kamilmysliwiec Awaiting requested review from kamilmysliwiec

Assignees
No one assigned
Labels
scope: platform status: blocked 🚫
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@alexfriesen @coveralls @flamewow @Tony133 @micalevisk @kamilmysliwiec