Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to express v5, fastify v5, add legacy route path converter #14238

Merged
merged 9 commits into from
Dec 16, 2024

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec added scope: core scope: platform dependencies Pull requests that update a dependency file labels Nov 28, 2024
@kamilmysliwiec kamilmysliwiec added this to the 11.0.0 milestone Nov 28, 2024
@kamilmysliwiec kamilmysliwiec changed the title chore(deps): upgrade to express v5, add legacy route path converter chore(deps): upgrade to express v5, fastify v5, add legacy route path converter Nov 28, 2024
@kamilmysliwiec kamilmysliwiec mentioned this pull request Nov 28, 2024
12 tasks
@coveralls
Copy link

coveralls commented Nov 28, 2024

Pull Request Test Coverage Report for Build 0a814cf0-29c6-4dee-8874-62bc2189010f

Details

  • 31 of 42 (73.81%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 89.757%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/middleware/utils.ts 7 10 70.0%
packages/core/router/legacy-route-converter.ts 17 21 80.95%
packages/core/router/router-explorer.ts 6 10 60.0%
Totals Coverage Status
Change from base Build cab6d4a2-2a29-4d37-84b8-35b7d0e3fb15: -0.1%
Covered Lines: 7098
Relevant Lines: 7908

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit cb739ad into 11.0.0 Dec 16, 2024
2 of 3 checks passed
@cwebb612
Copy link

cwebb612 commented Jan 10, 2025

@kamilmysliwiec
Does this unblock: nestjs/serve-static#1513 (comment) ?
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file scope: core scope: platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants