Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC Advanced protobuf related tests added to match documentation update coming for microservices/gRPC #2075

Conversation

anton-alation
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Other... Please describe:

Tests added for protobuf namespaced case:

  • loading with a single root file
  • namespaced dependencies in proto
  • @Client configuration load with namespace extension
  • Stream handlers

What is the current behavior?

Currently only simplified proto loading and tests introduced.

Issue Number: N/A

What is the new behavior?

A little bit more tests for advanced protobuf conception introduced, along with proto examples.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@coveralls
Copy link

coveralls commented Apr 24, 2019

Pull Request Test Coverage Report for Build 2536

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.601%

Totals Coverage Status
Change from base Build 2188: 0.0%
Covered Lines: 3098
Relevant Lines: 3251

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

Thanks! I'll look at it shortly

@kamilmysliwiec kamilmysliwiec merged commit bf17608 into nestjs:anton-alation-grpc-stream-duplex-decorator May 30, 2019
@kamilmysliwiec
Copy link
Member

Thank you!

@lock
Copy link

lock bot commented Sep 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants