Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(microservice): handle promise return by 'registerModules' properly #5136

Conversation

danielscw
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5135

What is the new behavior?

Allow error inside onModuleInit to properly bubble up and be able to be catch inside bootstrap function.
Resolve the UnhandledPromiseRejectionWarning issue.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

coveralls commented Jul 23, 2020

Pull Request Test Coverage Report for Build 4f36817b-7262-4880-a347-4761fa238994

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.817%

Totals Coverage Status
Change from base Build ffdcbe90-9390-4ce6-ac40-f441be5ae96a: 0.0%
Covered Lines: 4921
Relevant Lines: 5190

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec added this to the 7.4.0 milestone Jul 29, 2020
@kamilmysliwiec kamilmysliwiec merged commit c420898 into nestjs:master Jul 29, 2020
@kamilmysliwiec
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants