fix(sse): stream sink content #9000
Merged
+14
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8877
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using SSE feature, the first message received by client contains only colons (":").
Issue Number: #8877
What is the new behavior?
When using SSE feature, the first message received by client contains only newline character ("\n").
Does this PR introduce a breaking change?
N/A
Other information
I chose to keep the newline character as suggested by @jpineaufr. I think it was added to pretty print the message. Also, we could improve tests readability with some utility functions to encapsulate parts of the code and make use of "give", "when" and "then", like so: