Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(microservices): add commit-offsets function to clientkafka #9270

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

davidschuette
Copy link
Contributor

@davidschuette davidschuette commented Feb 28, 2022

This commit closes issue #9258.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #9258

What is the new behavior?

ClientKafka provides access to commitOffsets function from kafkajs.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@davidschuette
Copy link
Contributor Author

I will create a PR for the updated doc as soon as possible.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 04e7878c-ea71-45a0-8a95-fe362ff0e61f

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 94.11%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/client/client-kafka.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 01266412-f77f-45f6-a650-ea1dafba9f72: -0.05%
Covered Lines: 5720
Relevant Lines: 6078

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec kamilmysliwiec merged commit 7df7e3a into nestjs:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants